On 06/16/2010 01:51 PM, huang ying wrote:
On Tue, Jun 15, 2010 at 7:22 PM, Avi Kivity<avi@xxxxxxxxxx> wrote:
btw, is_hwpoison_address() is racy. While it looks up the address, some
other task can unmap the page tables under us.
Andi/Huang?
One way of fixing it is get_user_pages_ptes_fast(), which also returns the
pte, also atomically. I want it for other reasons as well (respond to a
read fault by gupping the page for read, but allowing write access if the
pte indicates it is writeable).
Yes. is_hwpoison_address() is racy. But I think it is not absolutely
necessary to call is_hwpoison_address() in hva_to_pfn_atomic(), is it?
We can probably ignore it, yes.
For is_hwpoison_address() in hva_to_pfn(), we can protect it with mmap_sem.
Not very appealing, but should work.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html