On 1/29/25 6:39 PM, Jason Gunthorpe wrote: > On Wed, Jan 29, 2025 at 06:23:33PM +0100, Eric Auger wrote: >>>> IIUC the MSI window will then be different when using legacy VFIO >>>> assignment and iommufd backend. >>> ? They use the same, iommufd can have userspace override it. Then it >>> will ignore the reserved region. >> In current arm-smmu-v3.c you have >> region = iommu_alloc_resv_region(MSI_IOVA_BASE, MSI_IOVA_LENGTH, >> prot, IOMMU_RESV_SW_MSI, >> GFP_KERNEL); >> >> in arm_smmu_get_resv_regions() >> If you overwrite the default region, don't you need to expose the user >> defined resv region? > If it was overriden inside iommufd then the user told the kernel what > range to use to override it. I don't need to go back and report back > to userspace information that it already gave to the kernel.. Looks strange to me because info exposed in sysfs is wrong then. What if someone else relies on this info, either at kernel level through the get_resv_regions callback or from user space. > >>> Nothing using iommufd should parse that sysfs file. >> Right but aren't you still supposed to populate the sysfs files >> properly. This region must be carved out from the IOVA space, right? > The sysfs shouldn't be changed here based on how iommufd decides to > use the iova space. The sysfs reflects the information reported from > the driver and sw_msi should be understood as the driver's > recommendation when you view it from sysfs. > > The actual reserved regions in effect for an iommufd object are > queried directly in iommufd and do not have a sysfs representation. > >>>>> + * @IOMMU_OPTION_SW_MSI_START: >>>>> + * Change the base address of the IOMMU mapping region for MSI doorbell(s). >>>>> + * It must be set this before attaching a device to an IOAS/HWPT, otherwise >>>>> + * this option will be not effective on that IOAS/HWPT. User can choose to >>>>> + * let kernel pick a base address, by simply ignoring this option or setting >>>>> + * a value 0 to IOMMU_OPTION_SW_MSI_SIZE. Global option, object_id must be 0 >>>> I think we should document it cannot be put at a random place either. >>> It can be put at any place a map can be placed. >> to me It cannot overlap with guest RAM IPA so userspace needs to be >> cautious about that > Yes, userspace needs to manage its own VM memory map to avoid > overlaps, but from an API perspective it can be placed anywhere that a > map can be placed. OK Eric > > Jason >
