>> +static int nvgrace_gpu_wait_device_ready(struct pci_dev *pdev) >> +{ >> + unsigned long timeout = jiffies + msecs_to_jiffies(POLL_TIMEOUT_MS); >> + void __iomem *io; >> + int ret = -ETIME; >> + >> + ret = pci_enable_device(pdev); >> + if (ret) >> + return ret; >> + >> + ret = pci_request_selected_regions(pdev, 1 << 0, "vfio-pci"); > > All the overhead of enabling the device and requesting the region, only > to undo it around this simple test is unfortunate, but I think correct. Yeah, thanks for guiding through that. > Even though this is only briefly taken, I'd suggest using KBUILD_MODNAME > there rather than "vfio-pci" to differentiate from the core code. > Thanks, > > Alex Understood, will make the change.