Bugs item #1945129, was opened at 2008-04-17 19:36 Message generated for change (Comment added) made by jessorensen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1945129&group_id=180599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Duilio J. Protti (dprotti) Assigned to: Nobody/Anonymous (nobody) Summary: Compilation fails when configure with -DDEBUG Initial Comment: When configured kvm-65 with ./configure --prefix=/usr/devel --qemu-cflags=-DDEBUG Compilation fails with the following error: gcc34 -I /root/linux/kvm-65/qemu/../libkvm -DDEBUG -DCONFIG_X86 -Wall -O2 -g -fno-strict-aliasing -m32 -I. -I/root/linux/kvm-65/qemu -MMD -MP -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/root/linux/kvm-65/qemu/slirp -c -o smbus_eeprom.o /root/linux/kvm-65/qemu/hw/smbus_eeprom.c /root/linux/kvm-65/qemu/hw/smbus_eeprom.c: In function `eeprom_quick_cmd': /root/linux/kvm-65/qemu/hw/smbus_eeprom.c:40: error: structure has no member named `addr' /root/linux/kvm-65/qemu/hw/smbus_eeprom.c: In function `eeprom_send_byte': /root/linux/kvm-65/qemu/hw/smbus_eeprom.c:48: error: structure has no member named `addr' /root/linux/kvm-65/qemu/hw/smbus_eeprom.c: In function `eeprom_receive_byte': /root/linux/kvm-65/qemu/hw/smbus_eeprom.c:58: error: structure has no member named `addr' /root/linux/kvm-65/qemu/hw/smbus_eeprom.c: In function `eeprom_write_data': /root/linux/kvm-65/qemu/hw/smbus_eeprom.c:68: error: structure has no member named `addr' make[1]: *** [smbus_eeprom.o] Error 1 make[1]: Leaving directory `/root/linux/kvm-65/qemu' make: *** [qemu] Error 2 The error comes because structure SMBusDevice does not have a field named 'addr' (probably name has changed since the debugging code was written). Code conditionally compiled with a DEBUG macro appears in many places in the Qemu code, but it is not driven by a central --debug option or similar, so it seems that the configuration in question (with -DDEBUG) is a little odd and a not supported one. However, may be the code should be changed or else removed to avoid these useless lines there. Attached is a simple patch which resolves the issue. Regards, Duilio Protti. ---------------------------------------------------------------------- >Comment By: Jes Sorensen (jessorensen) Date: 2010-06-15 17:07 Message: Hi, I was able to reproduce this, two patches have been pushed into upstream which should fix the problem: 271248886e6110b4af0545f6a2d3ef38217cd58f ac7045cff7db837cfcc552bdc0f0baa15699f21a Closing Jes ---------------------------------------------------------------------- Comment By: Duilio J. Protti (dprotti) Date: 2008-05-29 20:11 Message: Logged In: YES user_id=1012656 Originator: YES OK, done. Duilio. ---------------------------------------------------------------------- Comment By: Anthony Liguori (aliguori) Date: 2008-05-27 15:33 Message: Logged In: YES user_id=120449 Originator: NO Please submit your fix to qemu-devel ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1945129&group_id=180599 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
