On Fri, Jan 10, 2025 at 12:12:44PM +0100, Clément Léger wrote: > Add SBI SSE extension tests for the following features: > - Test attributes errors (invalid values, RO, etc) > - Registration errors > - Simple events (register, enable, inject) > - Events with different priorities > - Global events dispatch on different harts > - Local events on all harts > - Hart mask/unmask events > > Signed-off-by: Clément Léger <cleger@xxxxxxxxxxxx> > --- > riscv/Makefile | 3 +- > lib/riscv/asm/csr.h | 2 + > riscv/sse.h | 41 ++ > riscv/sse-asm.S | 104 +++++ > riscv/sbi-asm-offsets.c | 8 + > riscv/sbi-sse.c | 936 ++++++++++++++++++++++++++++++++++++++++ > riscv/sbi.c | 3 + > riscv/sse.c | 132 ++++++ I'm not reviewing this whole file since I have comments on v4 that I think mostly apply. However, I noticed the new riscv/sse.[ch] files being added. Those should have 'sbi' somewhere in their names or, if they just define wrappers for the SSE functions (not test-specific stuff), then they can go in lib/riscv/sbi.c. Remaining test-specific stuff should stay in the riscv dir. Header stuff could go in riscv/sbi-tests.h or a new riscv/sbi-sse.h. Everything else should be in riscv/sbi-sse.c And riscv/sse-asm.S should be named riscv/sbi-sse-asm.S Thanks, drew
