On 1/14/25 14:03, Paolo Bonzini wrote: > On 1/3/25 19:02, Edgecombe, Rick P wrote: >>> +u64 tdh_mr_extend(struct tdx_td *td, u64 gpa, u64 *rcx, u64 *rdx) >> >> gpa should be type gpa_t to avoid bare u64 types. > > gpa_t is defined in kvm_types.h, I am not sure arch/x86/virt should > include it. Yeah, _ideally_ we'd just keep it one type across the stack, but I can understand why the KVM folks wouldn't want it to leave KVM-specific code. My biggest beef elsewhere was with the indiscriminate use of u64. Using it for passing a gpa which is also 64-bits is far from indiscriminate. It's fine.
