Re: [PATCH v4 7/7] system/physmem: Memory settings applied on remap notification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10.01.25 21:57, William Roche wrote:
On 1/8/25 22:53, David Hildenbrand wrote:
On 14.12.24 14:45, “William Roche wrote:
From: William Roche <william.roche@xxxxxxxxxx>

Merging and dump settings are handled by the remap notification
in addition to memory policy and preallocation.

Signed-off-by: William Roche <william.roche@xxxxxxxxxx>
---
   system/physmem.c | 2 --
   1 file changed, 2 deletions(-)

diff --git a/system/physmem.c b/system/physmem.c
index 9fc74a5699..c0bfa20efc 100644
--- a/system/physmem.c
+++ b/system/physmem.c
@@ -2242,8 +2242,6 @@ void qemu_ram_remap(ram_addr_t addr)
                       }
                       qemu_ram_remap_mmap(block, vaddr, page_size,
offset);
                   }
-                memory_try_enable_merging(vaddr, page_size);
-                qemu_ram_setup_dump(vaddr, page_size);
                   ram_block_notify_remap(block->host, offset, page_size);
               }

Ah yes, indeed.

I also merged this patch 7/7 [system/physmem: Memory settings applied on
remap notification] into your patch 6/7 [hostmem: Handle remapping of
RAM], removing also the unneeded vaddr.

So now we are down to 6 patches  (unless you want me to integrate the
fix for ram_block_discard_range() I talked about for patch 2/7)

I'm sending my version v5 now.

Sorry for the delayed reply to v4.

--
Cheers,

David / dhildenb





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux