Re: [PATCH 1/1] KVM: VMX: Fix comment of handle_vmx_instruction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 03 Jan 2025 23:38:14 +0800, Gao Shiyuan wrote:
> There is no nested_vmx_setup function.

When referencing function, add parantheses, e.g. nested_vmx_setup(), so that it's
super obvious that you're talking about a function.

> It should be nested_vmx_hardware_setup overwrite the VMX emulate handler
> when nested=1.

Embarassingly, the comment was always wrong.  I added a paragraph to the changelog
to explain as much, e.g. so that we aren't as tempted to try and reword the comment
to avoid explicitly referencing function names so that it can't become stale.

Applied to kvm-x86 vmx, thanks!

[1/1] KVM: VMX: Fix comment of handle_vmx_instruction
      https://github.com/kvm-x86/linux/commit/4d141e444e26

--
https://github.com/kvm-x86/linux/tree/next




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux