Re: [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages
From: Dave Hansen <dave.hansen@xxxxxxxxx>
Date: Tue, 7 Jan 2025 17:20:52 -0800
Cc: "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "pbonzini@xxxxxxxxxx" <pbonzini@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "sean.j.christopherson@xxxxxxxxx" <sean.j.christopherson@xxxxxxxxx>, "Huang, Kai" <kai.huang@xxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "Yamahata, Isaku" <isaku.yamahata@xxxxxxxxx>
In-reply-to: <Z33Q/4piC/QMdPFQ@yzhao56-desk.sh.intel.com>
References: <20250101074959.412696-1-pbonzini@redhat.com> <20250101074959.412696-8-pbonzini@redhat.com> <b27448f5fc3bc96ae4c166e6eb4886e2ff8b4f90.camel@intel.com> <753cd9f1-5eb7-480f-ae4f-d263aaecdd6c@intel.com> <Z33Q/4piC/QMdPFQ@yzhao56-desk.sh.intel.com>
User-agent: Mozilla Thunderbird

On 1/7/25 17:12, Yan Zhao wrote:
> So, why does this bitfields definition make things worse?

Look at the kernel page table management. Why don't we use bitfields for
_that_? Look at the link I sent. Bitfields can cause some really goofy
unexpected behavior if you pass them around like they were a full type.

Follow-Ups:
- Re: [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages
  - From: Edgecombe, Rick P

References:
- [PATCH v2 00/13] x86/virt/tdx: Add SEAMCALL wrappers for KVM
  - From: Paolo Bonzini
- [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages
  - From: Paolo Bonzini
- Re: [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages
  - From: Edgecombe, Rick P
- Re: [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages
  - From: Dave Hansen
- Re: [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages
  - From: Yan Zhao

Prev by Date: Re: [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages
Next by Date: Re: [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages
Previous by thread: Re: [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages
Next by thread: Re: [PATCH 07/13] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]