Can confirm. Reverting f9e54c3a2f5b from v6.13-rc1 fixed the problem. -------- Original Message -------- On 23/12/24 04:06, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > Forwarding since not everybody follows bugzilla. Apparently bisected > to f9e54c3a2f5b ("vfio/pci: implement huge_fault support"). > > Athul, f9e54c3a2f5b appears to revert cleanly from v6.13-rc1. Can you > verify that reverting it is enough to avoid these artifacts? > > #regzbot introduced: f9e54c3a2f5b ("vfio/pci: implement huge_fault support") > > ----- Forwarded message from bugzilla-daemon@xxxxxxxxxx ----- > > Date: Sat, 21 Dec 2024 10:10:02 +0000 > From: bugzilla-daemon@xxxxxxxxxx > To: bjorn@xxxxxxxxxxxxxxxxxxxxxxx > Subject: [Bug 219619] New: vfio-pci: screen graphics artifacts after 6.12 kernel upgrade > Message-ID: <bug-219619-41252@xxxxxxxxxxxxxxxxxxxxxxxxx/> > > https://bugzilla.kernel.org/show_bug.cgi?id=219619 > > Bug ID: 219619 > Summary: vfio-pci: screen graphics artifacts after 6.12 kernel > upgrade > Product: Drivers > Version: 2.5 > Hardware: AMD > OS: Linux > Status: NEW > Severity: normal > Priority: P3 > Component: PCI > Assignee: drivers_pci@xxxxxxxxxxxxxxxxxxxx > Reporter: athul.krishna.kr@xxxxxxxxxxxxxx > Regression: No > > Created attachment 307382 > --> https://bugzilla.kernel.org/attachment.cgi?id=307382&action=edit > dmesg > > Device: Asus Zephyrus GA402RJ > CPU: Ryzen 7 6800HS > GPU: RX 6700S > Kernel: 6.13.0-rc3-g8faabc041a00 > > Problem: > Launching games or gpu bench-marking tools in qemu windows 11 vm will cause > screen artifacts, ultimately qemu will pause with unrecoverable error. > > Commit: > f9e54c3a2f5b79ecc57c7bc7d0d3521e461a2101 is the first bad commit > commit f9e54c3a2f5b79ecc57c7bc7d0d3521e461a2101 > Author: Alex Williamson <alex.williamson@xxxxxxxxxx> > Date: Mon Aug 26 16:43:53 2024 -0400 > > vfio/pci: implement huge_fault support > > With the addition of pfnmap support in vmf_insert_pfn_{pmd,pud}() we can > take advantage of PMD and PUD faults to PCI BAR mmaps and create more > efficient mappings. PCI BARs are always a power of two and will typically > get at least PMD alignment without userspace even trying. Userspace > alignment for PUD mappings is also not too difficult. > > Consolidate faults through a single handler with a new wrapper for > standard single page faults. The pre-faulting behavior of commit > d71a989cf5d9 ("vfio/pci: Insert full vma on mmap'd MMIO fault") is removed > in this refactoring since huge_fault will cover the bulk of the faults and > results in more efficient page table usage. We also want to avoid that > pre-faulted single page mappings preempt huge page mappings. > > Link: https://lkml.kernel.org/r/20240826204353.2228736-20-peterx@xxxxxxxxxx > Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx> > Signed-off-by: Peter Xu <peterx@xxxxxxxxxx> > Cc: Alexander Gordeev <agordeev@xxxxxxxxxxxxx> > Cc: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxx> > Cc: Borislav Petkov <bp@xxxxxxxxx> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx> > Cc: Christian Borntraeger <borntraeger@xxxxxxxxxxxxx> > Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> > Cc: David Hildenbrand <david@xxxxxxxxxx> > Cc: Gavin Shan <gshan@xxxxxxxxxx> > Cc: Gerald Schaefer <gerald.schaefer@xxxxxxxxxxxxx> > Cc: Heiko Carstens <hca@xxxxxxxxxxxxx> > Cc: Ingo Molnar <mingo@xxxxxxxxxx> > Cc: Jason Gunthorpe <jgg@xxxxxxxxxx> > Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx> > Cc: Niklas Schnelle <schnelle@xxxxxxxxxxxxx> > Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx> > Cc: Ryan Roberts <ryan.roberts@xxxxxxx> > Cc: Sean Christopherson <seanjc@xxxxxxxxxx> > Cc: Sven Schnelle <svens@xxxxxxxxxxxxx> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx> > Cc: Will Deacon <will@xxxxxxxxxx> > Cc: Zi Yan <ziy@xxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > drivers/vfio/pci/vfio_pci_core.c | 60 ++++++++++++++++++++++++++++------------ > 1 file changed, 43 insertions(+), 17 deletions(-) > > -- > You may reply to this email to add a comment. > > You are receiving this mail because: > You are watching the assignee of the bug. > > ----- End forwarded message ----- >