On Mon, 16 Dec 2024 19:28:24 +0000, Mark Brown wrote:
> In commit 03c7527e97f7 ("KVM: arm64: Do not allow ID_AA64MMFR0_EL1.ASIDbits
> to be overridden") we made that bitfield in the ID registers unwritable
> however the change neglected to make the corresponding update to set_id_regs
> resulting in it failing:
>
> # ok 56 ID_AA64MMFR0_EL1_BIGEND
> # ==== Test Assertion Failure ====
> # aarch64/set_id_regs.c:434: masks[idx] & ftr_bits[j].mask == ftr_bits[j].mask
> # pid=5566 tid=5566 errno=22 - Invalid argument
> # 1 0x00000000004034a7: test_vm_ftr_id_regs at set_id_regs.c:434
> # 2 0x0000000000401b53: main at set_id_regs.c:684
> # 3 0x0000ffff8e6b7543: ?? ??:0
> # 4 0x0000ffff8e6b7617: ?? ??:0
> # 5 0x0000000000401e6f: _start at ??:?
> # 0 != 0xf0 (masks[idx] & ftr_bits[j].mask != ftr_bits[j].mask)
> not ok 8 selftests: kvm: set_id_regs # exit=254
>
> [...]
Applied to fixes, thanks!
[1/1] KVM: arm64: Fix set_id_regs selftest for ASIDBITS becoming unwritable
https://git.kernel.org/kvmarm/kvmarm/c/212fbabe1dfe
--
Best,
Oliver
