On Wed, Dec 11, 2024 at 11:44:14PM +0000, Will Deacon wrote: > On Thu, 28 Nov 2024 15:12:42 +0000, Alexandru Elisei wrote: > > (resending because I accidently only sent the cover letter, sorry for that) > > > > The first 3 patches are fixes to kvm__arch_load_kernel_image(). I've CC'ed > > the riscv maintainer because it looks to me like riscv is similarly > > affected. > > > > Patch #4 ("arm64: Increase the payload memory region size to 512MB") might > > be controversial. Follows a bug report I received from Abdollahi Sina in > > private. Details in the commit message, but the gist of the patch is that > > the memory region where kernel + initrd + DTB are copied to are changed > > from 256MB to 512MB. As a result, the DTB and initrd are moved from below > > ram_start + 256MB to ram_start + 512MB to accomodate a larger initrd. If > > users rely on finding the DTB and initrd at the current addresses, then I'm > > not sure the patch is justified - after all, if someone really wants to use > > such a large initrd instead of a disk image with virtio, then replacing > > SZ_256M with SZ_512M locally doesn't look like a big ask. > > > > [...] > > Applied to arm64 (sina), thanks! > > [1/4] arm: Fix off-by-one errors when computing payload memory layout > https://git.kernel.org/arm64/c/167aa1e > [2/4] arm: Check return value for host_to_guest_flat() > https://git.kernel.org/arm64/c/ca57fb6 > [3/4] arm64: Use the kernel header image_size when loading into memory > https://git.kernel.org/arm64/c/32345de > [4/4] arm64: Increase the payload memory region size to 512MB > https://git.kernel.org/arm64/c/9b26a8e Sorry, these links are all broken as I generated the thankyou note against a testing branch. Rest assured that the changes are pushed to the kvmtool.git: https://git.kernel.org/pub/scm/linux/kernel/git/will/kvmtool.git/ Will