On Wed, 2024-12-04 at 11:54 -0800, Dave Hansen wrote: > On 12/2/24 17:03, Rick Edgecombe wrote: > > +u64 tdh_mng_addcx(struct tdx_td *td, struct page *tdcs_page) > > +{ > > + struct tdx_module_args args = { > > + .rcx = page_to_pfn(tdcs_page) << PAGE_SHIFT, > > This is a nit, but there is a page_to_phys(). I almost used that, but the macro casts to dma_addr_t which didn't quite fit these callers. Seems ok though.