On 11/27/24 14:42, Sean Christopherson wrote: > On Wed, Nov 27, 2024, Aaron Lewis wrote: > > I'll write a changelog for this too. > >> Note, a "FIXME" tag was added to svm_msr_filter_changed(). This will > > Write changelogs in imperative mood, i.e. state what the patch is doing as a > command. Don't describe what will have happened after the patch is applied. > Using imperative mood allows for using indicative mood to describe what was > already there, and/or what happened in the past. > >> be addressed later in the series after the VMX style MSR intercepts >> are added to SVM. >> >> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx> >> Co-developed-by: Aaron Lewis <aaronlewis@xxxxxxxxxx> > > Your SoB is needed here too. See "When to use Acked-by:, Cc:, and Co-developed-by:" > in Documentation/process/submitting-patches.rst. And actually, since the From: is Aaron's name, Sean needs to be listed as the Co-developed-by: (with his Signed-off-by:) and not Aaron. Thanks, Tom >
