Hi Luiz,
Thanks for your feedback.
On 06/10/2010 02:07 AM, Luiz Capitulino wrote:
On Tue, 8 Jun 2010 12:34:37 +0530
Prerna Saxena<prerna@xxxxxxxxxxxxxxxxxx> wrote:
This introduces the monitor command 'trace' to read current contents of
trace buffer.
...
diff --git a/simpletrace.c b/simpletrace.c
index 2fec4d3..8f33a81 100644
--- a/simpletrace.c
+++ b/simpletrace.c
@@ -62,3 +62,18 @@ void trace4(TraceEvent event, unsigned long x1, unsigned long x2, unsigned long
void trace5(TraceEvent event, unsigned long x1, unsigned long x2, unsigned long x3, unsigned long x4, unsigned long x5) {
trace(event, x1, x2, x3, x4, x5);
}
+
+void do_info_trace(Monitor *mon) {
You sure this shouldn't be 'info trace'?
In this set, I had a direct monitor command 'trace' to display trace
buffer contents.
In v2, I have introduced an 'info trace' command to do the same, since
it intuitively made more sense to use an 'info' command to see state of
trace buffer. For this implementation, the present handler name makes
more sense.(do_info_trace())
+ static unsigned int i, max_idx;
Why static?
This isnt needed. The next patch in this series removed it (This change
should've been a part of this patch, but went into next)
Cleaned it up in v2.
+
+ if (trace_idx)
+ max_idx = trace_idx;
+ else
+ max_idx = TRACE_BUF_LEN;
max_idx = trace_idx ? trace_idx : TRACE_BUF_LEN;
+
+ for (i=0; i<max_idx ;i++)
+ monitor_printf(mon, "Event %ld : %ld %ld %ld %ld %ld\n",
+ trace_buf[i].event, trace_buf[i].x1, trace_buf[i].x2,
+ trace_buf[i].x3, trace_buf[i].x4, trace_buf[i].x5);
Style& indentation.
Changed in v2.
+ return;
Not needed.
Removed in v2.
+}
diff --git a/tracetool b/tracetool
....
--
Prerna Saxena
Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
