On 12/2/24 14:57, Tom Lendacky wrote: > On 11/27/24 18:43, Sean Christopherson wrote: >> @@ -10071,13 +10072,15 @@ unsigned long __kvm_emulate_hypercall(struct kvm_vcpu *vcpu, unsigned long nr, >> } >> >> out: >> - return ret; >> + vcpu->run->hypercall.ret = ret; >> + complete_hypercall(vcpu); >> + return 1; > > Should this do return complete_hypercall(vcpu) so that you get the > return code from kvm_skip_emulated_instruction()? Bah, ignore... already commented on by Xiaoyao. Thanks, Tom > > Thanks, > Tom >