Re: [PATCH] [19/23] KVM: Fix unused but set warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/10/2010 02:10 PM, Andi Kleen wrote:
No real bugs in this one, the real bug I found is in a separate
patch.


Index: linux-2.6.35-rc2-gcc/arch/x86/kvm/vmx.c
===================================================================
--- linux-2.6.35-rc2-gcc.orig/arch/x86/kvm/vmx.c
+++ linux-2.6.35-rc2-gcc/arch/x86/kvm/vmx.c
@@ -1624,10 +1624,9 @@ static void enter_pmode(struct kvm_vcpu
  static gva_t rmode_tss_base(struct kvm *kvm)
  {
  	if (!kvm->arch.tss_addr) {
-		struct kvm_memslots *slots;
  		gfn_t base_gfn;

-		slots = kvm_memslots(kvm);
+		kvm_memslots(kvm);
  		base_gfn = kvm->memslots->memslots[0].base_gfn +
  				 kvm->memslots->memslots[0].npages - 3;
  		return base_gfn<<  PAGE_SHIFT;

I think the base_gfn assignment below needs to use slots to get the rcu dereference correct. I'll apply the patch without this hunk and fix it independently.


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux