On Wed, Nov 20, 2024 at 05:34:32PM +0100, Valentin Schneider wrote: > On 20/11/24 15:59, Peter Zijlstra wrote: > > On Tue, Nov 19, 2024 at 04:34:55PM +0100, Valentin Schneider wrote: > >> Later commits will cause objtool to warn about non __ro_after_init static > >> keys being used in .noinstr sections in order to safely defer instruction > >> patching IPIs targeted at NOHZ_FULL CPUs. > >> > >> __sched_clock_stable is used in .noinstr code, and can be modified at > >> runtime (e.g. KVM module loading). Suppressing the text_poke_sync() IPI has > > > > Wait, what !? loading KVM causes the TSC to be marked unstable? > > There is however this: > > kvm_arch_vcpu_load() > `\ > mark_tsc_unstable() > > So plugging a VCPU might do that. Right, but that only happens if it observes the TSC doing dodgy, so that's deserved and shouldn't happen on hardware from this decade, and possibly the one before that.
