On 11/21/2024 2:48 AM, Sean Christopherson wrote: > On Fri, Oct 25, 2024, Zide Chen wrote: >> >> On 7/31/2024 9:58 PM, Mingwei Zhang wrote: >>> Introduce PMU operator for setting counter overflow. When emulating counter >>> increment, multiple counters could overflow at the same time, i.e., during >>> the execution of the same instruction. In passthrough PMU, having an PMU >>> operator provides convenience to update the PMU global status in one shot >>> with details hidden behind the vendor specific implementation. >> Since neither Intel nor AMD does implement this API, this patch should >> be dropped. > For all of these small APIs, please introduce and use the API in the same patch. > That avoids goofs like this, where something is never used, and makes the patches > far easier to review. Sure. >
