On Fri, 15 Nov 2024 14:56:11 +0100 Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx> wrote: > If the page has been exported, do not re-import it. Imports should > only be triggered by the guest. The guest will import the page > automatically when it will need it again, there is no advantage in > importing it manually. > > Moreover, vfio_pin_pages() will take an extra reference on the page and > thus will cause the import to always fail. The extra reference would be > dropped only after pointlessly trying to import the page. > > Fixes: f88fb1335733 ("s390/vfio-ap: make sure nib is shared") > Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx> Reviewed-by: Halil Pasic <pasic@xxxxxxxxxxxxx>