On 11/13/24 9:15 AM, Zhao Liu wrote: >>> Further, considering that this is currently the only case that needs to >>> to set the VM level's capability in the CPU context, there is no need to >>> introduce a new kvm interface (in your previous patch), which can instead >>> be set in kvm_cpu_realizefn(), like: >>> > > Now your case is not the only user of kvm_arch_pre_create_vcpu(), and > TDX also needs this [*]. So, this is the support for bringing back your > previous solution (preferably with comments, as I suggested earlier, > explaining why it's necessary to handle VM-level cap in the CPU > context). :-) > > [*]: https://urldefense.com/v3/__https://lore.kernel.org/qemu-devel/20241105062408.3533704-8-xiaoyao.li@xxxxxxxxx/__;!!ACWV5N9M2RV99hQ!PGJQ9Kv-1mo_4YX1fb4N9YvZZqHInebtCNcSniRi3qJNPIfG5zZnDp1b1gVmO-DdpYxMvO1hlH9owAHV5UMT$ > Thank you very much for the reminder! Dongli Zhang
