On Mon, Nov 11, 2024 at 11:34:47AM +0200, Andy Shevchenko wrote: > On Fri, Nov 08, 2024 at 09:48:51PM -0800, Nicolin Chen wrote: > > Now, the common __pci_alloc_irq_vectors() accepts an array of msi_iovas, > > which is a list of preset IOVAs for MSI doorbell addresses. > > > > Add a helper that would pass in a list. A following patch will call this > > to forward msi_iovas from user space. > > ... > > > +/** > > + * pci_alloc_irq_vectors_iovas() - Allocate multiple device interrupt > > + * vectors with preset msi_iovas > > + * @dev: the PCI device to operate on > > + * @min_vecs: minimum required number of vectors (must be >= 1) > > + * @max_vecs: maximum desired number of vectors > > + * @flags: allocation flags, as in pci_alloc_irq_vectors() > > + * @msi_iovas: list of IOVAs for MSI between [min_vecs, max_vecs] > > + * > > + * Same as pci_alloc_irq_vectors(), but with the extra @msi_iovas parameter. > > + * Check that function docs, and &struct irq_affinity, for more details. > > + */ > > Always validate your kernel-doc descriptions > > scripts/kernel-doc -Wall -none -v ... > > will give you a warning here. Will do in next round. Thanks! Nicolin