On Thu, Nov 07, 2024 at 10:04:03PM +0100, Michal Luczaj wrote:
On 11/7/24 11:22, Stefano Garzarella wrote:
On Wed, Nov 06, 2024 at 06:51:21PM +0100, Michal Luczaj wrote:
Macro vsock_connected_sockets_vsk() has been unused since its introduction.
Instead of removing it, utilise it in vsock_insert_connected() where it's
been open-coded.
No functional change intended.
Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
This is not a fix, so please remove the Fixes tag, we don't need to
backport this patch in stable branches.
Also in this case this is not related at all with virtio transport, so
please remove `virtio` from the commit title.
In addition maybe you can remove this patch from this series, and send
it to net-next.
...
Right, I get it. Just to be clear: are such small (and non-functional)
cleanups welcomed coming by themselves?
Good question, in this case I think it's a good cleanup, since we have
the function already there, why not use it. So I don't see a problem
with that.
If you find others cleanups, it's better to pack in a single series,
otherwise let's send just it.
Thanks for the fixes and cleanups!
Stefano
