>-----Original Message----- >From: Eric Dumazet [mailto:eric.dumazet@xxxxxxxxx] >Sent: Saturday, June 05, 2010 10:53 PM >To: Xin, Xiaohui >Cc: netdev@xxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >mst@xxxxxxxxxx; mingo@xxxxxxx; davem@xxxxxxxxxxxxx; herbert@xxxxxxxxxxxxxxxxxxx; >jdike@xxxxxxxxxxxxxxx >Subject: Re: [RFC PATCH v7 08/19] Make __alloc_skb() to get external buffer. > >Le samedi 05 juin 2010 à 18:14 +0800, xiaohui.xin@xxxxxxxxx a écrit : >> From: Xin Xiaohui <xiaohui.xin@xxxxxxxxx> >> child->fclone = SKB_FCLONE_UNAVAILABLE; >> } >> + /* Record the external buffer info in this field. It's not so good, >> + * but we cannot find another place easily. >> + */ >> + shinfo->destructor_arg = ext_page; >> + > > >Yes this is a big problem, its basically using a cache line that was not >touched before. > Did your patch which moves destructor_arg before frags[] also fix this? Thanks Xiaohui -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
