On Mon, Nov 04, 2024 at 05:20:27AM -0800, Yi Liu wrote: > driver should implement both set_dev_pasid and remove_dev_pasid op, otherwise > it is a problem how to detach pasid. In reality, it is impossible that an > iommu driver implements set_dev_pasid() but no remove_dev_pasid() op. However, > it is better to check it. > > Signed-off-by: Yi Liu <yi.l.liu@xxxxxxxxx> > --- > drivers/iommu/iommu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) I was wondering if we really needed this, but it does make the patches a bit easier to understand Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Jason
