Hi Joao, > -----Original Message----- > From: Joao Martins <joao.m.martins@xxxxxxxxxx> > Sent: Wednesday, October 30, 2024 3:47 PM > To: Jason Gunthorpe <jgg@xxxxxxxxxx>; Zhangfei Gao > <zhangfei.gao@xxxxxxxxxx> > Cc: iommu@xxxxxxxxxxxxxxx; Kevin Tian <kevin.tian@xxxxxxxxx>; Shameerali > Kolothum Thodi <shameerali.kolothum.thodi@xxxxxxxxxx>; Lu Baolu > <baolu.lu@xxxxxxxxxxxxxxx>; Yi Liu <yi.l.liu@xxxxxxxxx>; Yi Y Sun > <yi.y.sun@xxxxxxxxx>; Nicolin Chen <nicolinc@xxxxxxxxxx>; Joerg Roedel > <joro@xxxxxxxxxx>; Suravee Suthikulpanit > <suravee.suthikulpanit@xxxxxxx>; Will Deacon <will@xxxxxxxxxx>; Robin > Murphy <robin.murphy@xxxxxxx>; Zhenzhong Duan > <zhenzhong.duan@xxxxxxxxx>; Alex Williamson > <alex.williamson@xxxxxxxxxx>; kvm@xxxxxxxxxxxxxxx; Shameer Kolothum > <shamiali2008@xxxxxxxxx>; Wangzhou (B) <wangzhou1@xxxxxxxxxxxxx> > Subject: Re: [PATCH v6 00/18] IOMMUFD Dirty Tracking > > On 30/10/2024 15:36, Jason Gunthorpe wrote: > > On Wed, Oct 30, 2024 at 11:15:02PM +0800, Zhangfei Gao wrote: > >> hw/vfio/migration.c > >> if (vfio_viommu_preset(vbasedev)) { > >> error_setg(&err, "%s: Migration is currently not supported " > >> "with vIOMMU enabled", vbasedev->name); > >> goto add_blocker; > >> } > > > > The viommu driver itself does not support live migration, it would > > need to preserve all the guest configuration and bring it all back. It > > doesn't know how to do that yet. > > It's more of vfio code, not quite related to actually hw vIOMMU. > > There's some vfio migration + vIOMMU support patches I have to follow up > (v5) Are you referring this series here? https://lore.kernel.org/qemu-devel/d5d30f58-31f0-1103-6956-377de34a790c@xxxxxxxxxx/T/ Is that enabling migration only if Guest doesn’t do any DMA translations? > but unexpected set backs unrelated to work delay some of my plans for > qemu 9.2. > I expect to resume in few weeks. I can point you to a branch while I don't > submit (provided soft-freeze is coming) Also, I think we need a mechanism for page fault handling in case Guest handles the stage 1 plus dirty tracking for stage 1 as well. Thanks, Shameer