On 10/29/24 09:27, Borislav Petkov wrote: > On Tue, Oct 29, 2024 at 05:19:29PM +0800, Xiaoyao Li wrote: >> IMHO, it's a bad starter. > > What does a "bad starter" mean exactly? > >> As more and more SNP features will be enabled in the future, a SNP init >> function like tdx_early_init() would be a good place for all SNP guest >> stuff. > > There is already a call to sme_early_init() around that area. It could be > repurposed for SEV/SNP stuff too... Yes, the early call to sme_early_init() is meant for SME, SEV, SEV-ES and SEV-SNP since we have to support them all and currently does initialization for all of these. It is analogous to the tdx_early_init() call. TDX also makes use of initialization that happens in mem_encrypt_init() and mem_encrypt_setup_arch(), so it doesn't only use tdx_early_init(). Thanks, Tom >
