Re: [PATCH v6 03/10] x86/virt/tdx: Use auto-generated code to read global metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




   1) Using the generated C is simple.
   2) Adding a field is dirty simple, e.g., the script just pulls the

Probably meant "dirt simple", but if this is fixed up on apply I'd drop
the idiom and just say "simple".

Yeah "dirt simple". I missed this. Will just say "simple" if a new version is needed.

[...]


Link: https://lore.kernel.org/lkml/4b3adb59-50ea-419e-ad02-e19e8ca20dee@xxxxxxxxx/ [1]
Link: https://lore.kernel.org/all/fc0e8ab7-86d4-4428-be31-82e1ece6dd21@xxxxxxxxx/ [2]
Link: https://lore.kernel.org/kvm/0853b155ec9aac09c594caa60914ed6ea4dc0a71.camel@xxxxxxxxx/ [5]

Just an fyi, that lore accepts the simple:

https://lore.kernel.org/$msg_id

...format, no need to record the list name in the URL (127734e23aed
("Documentation: best practices for using Link trailers"))

Thanks for the info. I got those link by clicking the "permalink" on the webpage, and then I just paste.

Yeah "https://lore.kernel.org/$msg_id"; works, but if I open the page using this format the like is changed to:

  "https://lore.kernel.org/all/$msg_id";

So I thought I just don't bother to remove the "all/lkml/kvm" in the link. I'll change to use the simple format in the future since it is said in the Documentation.


Link: https://github.com/canonical/tdx/issues/135 [3]
Link: https://cdrdv2.intel.com/v1/dl/getContent/795381 [4]
Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Co-developed-by: Kai Huang <kai.huang@xxxxxxxxx>
Signed-off-by: Kai Huang <kai.huang@xxxxxxxxx>

Looks good to me, with or without the above nits addressed.

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Thanks.  I'll fixup if a new version is needed.





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux