On Mon, Oct 21, 2024 at 05:35:38PM +0800, Yi Liu wrote: > On 2024/10/18 22:39, Jason Gunthorpe wrote: > > On Thu, Oct 17, 2024 at 10:58:22PM -0700, Yi Liu wrote: > > > The iommu drivers are on the way to drop the remove_dev_pasid op by > > > extending the blocked_domain to support PASID. However, this cannot be > > > done in one shot. So far, the Intel iommu and the ARM SMMUv3 driver have > > > supported it, while the AMD iommu driver has not yet. During this > > > transition, the IOMMU core needs to support both ways to destroy the > > > attachment of device/PASID and domain. > > > > Let's just fix AMD? > > cool. You could probably do better on this and fixup amd_iommu_remove_dev_pasid() to have the right signature directly, like the other drivers did Jason
