On Thu, Oct 17, 2024 at 10:58:24PM -0700, Yi Liu wrote: > -static void intel_iommu_remove_dev_pasid(struct device *dev, ioasid_t pasid, > - struct iommu_domain *domain) > +static int blocking_domain_set_dev_pasid(struct iommu_domain *domain, > + struct device *dev, ioasid_t pasid, > + struct iommu_domain *old) > { > struct device_domain_info *info = dev_iommu_priv_get(dev); > struct intel_iommu *iommu = info->iommu; > @@ -4292,10 +4298,12 @@ static void intel_iommu_remove_dev_pasid(struct device *dev, ioasid_t pasid, > INTEL_PASID_TEARDOWN_DRAIN_PRQ); > > /* Identity domain has no meta data for pasid. */ > - if (domain->type == IOMMU_DOMAIN_IDENTITY) > - return; > + if (old->type == IOMMU_DOMAIN_IDENTITY) > + goto out; Just return 0 Jason