On 14/10/2024 22:37, Sean Christopherson wrote: > Nit, "KVM:" for the scope. Thanks, will fix. > > On Mon, Oct 14, 2024, Ryan Roberts wrote: >> To prepare for supporting boot-time page size selection, refactor code >> to remove assumptions about PAGE_SIZE being compile-time constant. Code >> intended to be equivalent when compile-time page size is active. >> >> Modify BUILD_BUG_ON() to compare with page size limit. >> >> Signed-off-by: Ryan Roberts <ryan.roberts@xxxxxxx> >> --- >> >> ***NOTE*** >> Any confused maintainers may want to read the cover note here for context: >> https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@xxxxxxx/ > > The patch should still stand on its own. Most people can probably suss out what > PAGE_SIZE_MIN is, but at the same time, it's quite easy to provide a more verbose > changelog that's tailored to the actual patch. E.g. > > To prepare for supporting boot-time page size selection, refactor KVM's > check on the size of the kvm_run structure to assert that the size is less > than the smallest possible page size, i.e. that kvm_run won't overflow its > page regardless of what page size is chosen at boot time. > > With something like the above, > > Reviewed-by: Sean Christopherson <seanjc@xxxxxxxxxx> Thanks! I'll update this for the next version.
