Re: [PATCH] msix: fix msix_set/unset_mask_notifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 02, 2010 at 08:49:35PM +0300, Michael S. Tsirkin wrote:
> Sridhar Samudrala reported hitting the following assertions
> in msix.c when doing a guest reboot or live migration using vhost.
> qemu-kvm/hw/msix.c:375: msix_mask_all: Assertion `r >= 0' failed.
> qemu-kvm/hw/msix.c:640: msix_unset_mask_notifier:
> Assertion `dev->msix_mask_notifier_opaque[vector]' failed.
> 
> The issue is that we didn't clear/set the opaque pointer
> when vector is masked. The following patch fixes this.
> 
> Signed-off-by: Sridhar Samudrala <sri@xxxxxxxxxx>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
> 
> Sridhar, could you test the following please?
> 
>  hw/msix.c |   33 ++++++++++++++++-----------------
>  1 files changed, 16 insertions(+), 17 deletions(-)

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux