On Fri, Oct 04, 2024 at 04:05:17PM +0100, Steven Price wrote: > I should have reworded this commit message to something like: > > """ > Detect that the VM is a realm guest by the presence of the RSI > interface. This is done after PSCI has been initialised so that we can > check the SMCCC conduit before making any RSI calls. > > If in a realm then iterate over all memory ensuring that it is marked as > RIPAS RAM. The loader is required to do this for us, however if some > memory is missed this will cause the guest to receive a hard to debug > external abort at some random point in the future. So for a > belt-and-braces approach set all memory to RIPAS RAM. Any failure here > implies that the RAM regions passed to Linux are incorrect so panic() > promptly to make the situation clear. > """ With the updated commit description, the patch looks fine to me. Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx>
