On Tue, Oct 08, 2024 at 10:50:53AM +0100, Jonathan Cameron wrote: > Date: Tue, 8 Oct 2024 10:50:53 +0100 > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Subject: Re: [RFC v2 03/12] system/vl: Create CPU topology devices from CLI > early > X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) > > On Thu, 19 Sep 2024 14:11:19 +0800 > Zhao Liu <zhao1.liu@xxxxxxxxx> wrote: > > > Custom topology will allow user to build CPU topology from CLI totally, > > and this replaces machine's default CPU creation process (*_init_cpus() > > in MachineClass.init()). > > > > For the machine's initialization, there may be CPU dependencies in the > > remaining initialization after the CPU creation. > > > > To address such dependencies, create the CPU topology device (including > > CPU devices) from the CLI earlier, so that the latter part of machine > > initialization can be separated after qemu_add_cli_devices_early(). > > > > Signed-off-by: Zhao Liu <zhao1.liu@xxxxxxxxx> > Other than question of type of category from previous patch this looks > fine to me. > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > However, needs review from others more familiar with this code! Thanks! -Zhao
