Hi Ali, [snip] > > + > > + /* > > + * TODO: Add a SMPCompatProps.has_caches flag to avoid useless > > Updates > > + * if user didn't set smp_cache. > > + */ > Hi Zhao, > > Thanks for sending this patchset so quickly. I really appreciate the > TODO already :) Welcome! And I'm also sorry for a long silence. Now I'm back from the vacation and will keep pushing this series forward. > It also helps me avoid going through every single > layer, especially when I want to avoid matching system registers in > ARM, particularly when there's no description in the command line. Great! I also noticed your patch for this "TODO" and will help you review it soon. Regards, Zhao > > + x86_cpu_update_smp_cache_topo(ms, cpu); > > + > > qemu_register_reset(x86_cpu_machine_reset_cb, cpu); > > > > if (cpu->env.features[FEAT_1_EDX] & CPUID_APIC || ms->smp.cpus > > > 1) { >