On Wed, 02 Oct 2024 21:42:39 +0100, Marc Zyngier wrote: > Oliver reports that the kvm_has_feat() helper is not behaviing as > expected for negative feature. On investigation, the main issue > seems to be caused by the following construct: > > (id##_##fld##_SIGNED ? \ > get_idreg_field_signed(kvm, id, fld) : \ > get_idreg_field_unsigned(kvm, id, fld)) > > [...] Applied to fixes, thanks! [1/1] KVM: arm64: Fix kvm_has_feat*() handling of negative features commit: a1d402abf8e3ff1d821e88993fc5331784fac0da Cheers, M. -- Without deviation from the norm, progress is not possible.