Re: KVM: read apic->irr with ioapic lock held

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/02/2010 05:26 PM, Marcelo Tosatti wrote:
Read ioapic->irr inside ioapic->lock protected section.

KVM-Stable-Tag
Signed-off-by: Marcelo Tosatti<mtosatti@xxxxxxxxxx>

diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
index 3bc4fdb..1149c60 100644
--- a/virt/kvm/ioapic.c
+++ b/virt/kvm/ioapic.c
@@ -193,12 +193,13 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int irq)

  int kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level)
  {
-	u32 old_irr = ioapic->irr;
+	u32 old_irr;
  	u32 mask = 1<<  irq;
  	union kvm_ioapic_redirect_entry entry;
  	int ret = 1;

  	spin_lock(&ioapic->lock);
+	old_irr = ioapic->irr;
  	if (irq>= 0&&  irq<  IOAPIC_NUM_PINS) {
  		entry = ioapic->redirtbl[irq];
  		level ^= entry.fields.polarity;

Yikes.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux