On Thu, Sep 26, 2024 at 06:16:40PM +0200, Alexander Mikhalitsyn wrote:
> Add an explicit MODULE_VERSION("0.0.1") specification
> for a vhost_vsock module. It is useful because it allows
> userspace to check if vhost_vsock is there when it is
> configured as a built-in.
>
> Without this change, there is no /sys/module/vhost_vsock directory.
>
> With this change:
> $ ls -la /sys/module/vhost_vsock/
> total 0
> drwxr-xr-x 2 root root 0 Sep 26 15:59 .
> drwxr-xr-x 100 root root 0 Sep 26 15:59 ..
> --w------- 1 root root 4096 Sep 26 15:59 uevent
> -r--r--r-- 1 root root 4096 Sep 26 15:59 version
>
> Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@xxxxxxxxxxxxx>
Why not check that the misc device is registered?
I'd rather not add a new UAPI until actually necessary.
> ---
> drivers/vhost/vsock.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> index 802153e23073..287ea8e480b5 100644
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -956,6 +956,7 @@ static void __exit vhost_vsock_exit(void)
>
> module_init(vhost_vsock_init);
> module_exit(vhost_vsock_exit);
> +MODULE_VERSION("0.0.1");
> MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Asias He");
> MODULE_DESCRIPTION("vhost transport for vsock ");
> --
> 2.34.1
