On 06/01/2010 07:19 PM, Sridhar Samudrala wrote: >> - int i; >> + cpumask_var_t mask; >> + int i, ret = -ENOMEM; >> + >> + if (!alloc_cpumask_var(&mask, GFP_KERNEL)) >> + goto out_free_mask; > > I think this is another bug in the error path. You should simply > do a return instead of a goto here when aloc_cpu_mask fails. Oh... it's always safe to call free_cpumask_var() after failed alloc_cpumask_var(), so that part isn't broken. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
