On Thu, Sep 12, 2024 at 4:43 PM Edgecombe, Rick P <rick.p.edgecombe@xxxxxxxxx> wrote: > > On Thu, 2024-09-12 at 06:58 -0700, Sean Christopherson wrote: > > > Which clearly says it is checking the *faulting* GPA. > > > > I don't think that necessarily solves the problem either, because the reader > > has > > to know that the KVM looks at the shared bit. > > > > If open coding is undesirable > > Yea, I think it's used in enough places that a helper is worth it. > > > , maybe a very literal name, e.g. vmx_is_shared_bit_set()? > > Sure, thanks. I didn't see a problem with kvm_is_private_gpa(), but I do prefer something that has vmx_ or vt_ in the name after seeing it. My preference would go to something like vt_is_tdx_private_gpa(), but I'm not going to force one name or another. Paolo
