Re: [PATCH v2 43/48] hw/ppc: remove return after g_assert_not_reached()

Cédric Le Goater <clegoate@xxxxxxxxxx> · Thu, 12 Sep 2024 10:02:30 +0200

On 9/12/24 09:39, Pierrick Bouvier wrote:
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxx>


Reviewed-by: Cédric Le Goater <clg@xxxxxxxxxx>

Thanks,

C.


---
  hw/ppc/ppc.c          | 1 -
  hw/ppc/spapr_events.c | 1 -
  2 files changed, 2 deletions(-)

diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c
index e6fa5580c01..fde46194122 100644
--- a/hw/ppc/ppc.c
+++ b/hw/ppc/ppc.c
@@ -267,7 +267,6 @@ static void power9_set_irq(void *opaque, int pin, int level)
          break;
      default:
          g_assert_not_reached();
-        return;
      }
  }
  
diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c
index 38ac1cb7866..4dbf8e2e2ef 100644
--- a/hw/ppc/spapr_events.c
+++ b/hw/ppc/spapr_events.c
@@ -646,7 +646,6 @@ static void spapr_hotplug_req_event(uint8_t hp_id, uint8_t hp_action,
           * that don't support them
           */
          g_assert_not_reached();
-        return;
      }
  
      if (hp_id == RTAS_LOG_V6_HP_ID_DRC_COUNT) {








