Re: [PATCH 00/39] Use g_assert_not_reached instead of (g_)assert(0,false)

Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> · Wed, 11 Sep 2024 10:39:51 +0200

On 11/9/24 00:15, Pierrick Bouvier wrote:

Pierrick Bouvier (39):
   docs/spin: replace assert(0) with g_assert_not_reached()
   hw/acpi: replace assert(0) with g_assert_not_reached()
   hw/arm: replace assert(0) with g_assert_not_reached()
   hw/char: replace assert(0) with g_assert_not_reached()
   hw/core: replace assert(0) with g_assert_not_reached()
   hw/net: replace assert(0) with g_assert_not_reached()
   hw/watchdog: replace assert(0) with g_assert_not_reached()
   migration: replace assert(0) with g_assert_not_reached()
   qobject: replace assert(0) with g_assert_not_reached()
   system: replace assert(0) with g_assert_not_reached()
   target/ppc: replace assert(0) with g_assert_not_reached()
   tests/qtest: replace assert(0) with g_assert_not_reached()
   tests/unit: replace assert(0) with g_assert_not_reached()
   include/hw/s390x: replace assert(false) with g_assert_not_reached()
   block: replace assert(false) with g_assert_not_reached()
   hw/hyperv: replace assert(false) with g_assert_not_reached()
   hw/net: replace assert(false) with g_assert_not_reached()
   hw/nvme: replace assert(false) with g_assert_not_reached()
   hw/pci: replace assert(false) with g_assert_not_reached()
   hw/ppc: replace assert(false) with g_assert_not_reached()
   migration: replace assert(false) with g_assert_not_reached()
   target/i386/kvm: replace assert(false) with g_assert_not_reached()
   tests/qtest: replace assert(false) with g_assert_not_reached()
   accel/tcg: remove break after g_assert_not_reached()
   block: remove break after g_assert_not_reached()
   hw/acpi: remove break after g_assert_not_reached()
   hw/gpio: remove break after g_assert_not_reached()
   hw/misc: remove break after g_assert_not_reached()
   hw/net: remove break after g_assert_not_reached()
   hw/pci-host: remove break after g_assert_not_reached()
   hw/scsi: remove break after g_assert_not_reached()
   hw/tpm: remove break after g_assert_not_reached()
   target/arm: remove break after g_assert_not_reached()
   target/riscv: remove break after g_assert_not_reached()
   tests/qtest: remove break after g_assert_not_reached()
   ui: remove break after g_assert_not_reached()
   fpu: remove break after g_assert_not_reached()
   tcg/loongarch64: remove break after g_assert_not_reached()
   scripts/checkpatch.pl: emit error when using assert(false)

I'm queuing reviewed patches 4,5,7,10,27,28,30,36 so you don't
have to carry them in v2.

Regards,

Phil.