Re: [PATCH 19/39] hw/pci: replace assert(false) with g_assert_not_reached()

Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> · Wed, 11 Sep 2024 07:50:20 +0200

Hi Pierrick,

On 11/9/24 00:15, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxx>
---
  hw/pci/pci-stub.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c
index f0508682d2b..c6950e21bd4 100644
--- a/hw/pci/pci-stub.c
+++ b/hw/pci/pci-stub.c
@@ -46,13 +46,13 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict)
  /* kvm-all wants this */
  MSIMessage pci_get_msi_message(PCIDevice *dev, int vector)
  {
-    g_assert(false);
+    g_assert_not_reached();
      return (MSIMessage){};

The tail of this series remove the unreachable 'break' lines.
Why 'return' lines aren't problematic? Is that a GCC TSan bug?

  }
  
  uint16_t pci_requester_id(PCIDevice *dev)
  {
-    g_assert(false);
+    g_assert_not_reached();
      return 0;
  }
  








