On Tue, 2024-09-10 at 12:13 +0200, Paolo Bonzini wrote:
> > Yan, do you think it is sufficient?
>
> If you're actually requiring that the other locks are sufficient, then
> there can be no ENOENT.
>
> Maybe:
>
> /*
> * The private mem cannot be zapped after kvm_tdp_map_page()
> * because all paths are covered by slots_lock and the
> * filemap invalidate lock. Check that they are indeed enough.
> */
> if (IS_ENABLED(CONFIG_KVM_PROVE_MMU)) {
> scoped_guard(read_lock, &kvm->mmu_lock) {
> if (KVM_BUG_ON(kvm,
> !kvm_tdp_mmu_gpa_is_mapped(vcpu, gpa)) {
> ret = -EIO;
> goto out;
> }
> }
> }
True. We can put it behind CONFIG_KVM_PROVE_MMU.
