Re: [PATCH qemu-kvm] device-assignment: add config fd qdev property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 24, 2010 at 10:53:49AM -0600, Alex Williamson wrote:
> On Wed, 2010-05-19 at 12:00 -0700, Chris Wright wrote:
> > When libvirt launches a guest it first chowns the relevenat
> > /sys/bus/pci/.../config file for an assigned device then drops privileges.
> > 
> > This causes an issue for device assignment because despite being file
> > owner, the sysfs config space file checks for CAP_SYS_ADMIN before
> > allowing access to device dependent config space.
> > 
> > This adds a new qdev configfd property which allows libvirt to open the
> > sysfs config space file and give qemu an already opened file descriptor.
> > Along with a change pending for the 2.6.35 kernel, this allows the
> > capability check to compare against privileges from when the file was
> > opened.
> 
> We need to make configfd be a string option so that we can pass a
> descriptor from libvirt for the hotplug case.  Here's a rework.
> 
> Signed-off-by: Chris Wright <chrisw@xxxxxxxxxx>
> Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux