On 2024/9/8 19:42, Yi Liu wrote:
For the fault-capable hwpts, the iommufd_hwpt_detach_device() calls both iommufd_fault_domain_detach_dev() and iommu_detach_group(). This would have duplicated __iommu_group_set_core_domain() call since both functions call it in the end. This looks no harm as the __iommu_group_set_core_domain() returns if the new domain equals to the existing one. But it makes sense to avoid such duplicated calls in caller side. Signed-off-by: Yi Liu<yi.l.liu@xxxxxxxxx> --- drivers/iommu/iommufd/iommufd_private.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> Thanks, baolu
