On Wed, 2024-09-04 at 18:37 +0300, Adrian Hunter wrote: > > Isaku was going to lock the mmu. Seems like the change got lost. > To protect against racing with KVM_PRE_FAULT_MEMORY, > KVM_TDX_INIT_MEM_REGION, tdx_sept_set_private_spte() etc > e.g. Rename tdx_td_finalizemr to __tdx_td_finalizemr and add: > > static int tdx_td_finalizemr(struct kvm *kvm, struct kvm_tdx_cmd *cmd) > { > int ret; > > write_lock(&kvm->mmu_lock); > ret = __tdx_td_finalizemr(kvm, cmd); > write_unlock(&kvm->mmu_lock); > > return ret; > } Makes sense. Thanks.