Re: [PATCH] kvm/i386: declare kvm_filter_msr() static

Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> · Tue, 3 Sep 2024 15:23:03 +0200

On 3/9/24 08:50, Ani Sinha wrote:
kvm_filer_msr() is only used from i386 kvm module. Make it static so that its
easy for developers to understand that its not used anywhere else.

Signed-off-by: Ani Sinha <anisinha@xxxxxxxxxx>
---
  target/i386/kvm/kvm.c      | 4 +++-
  target/i386/kvm/kvm_i386.h | 3 ---
  2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/target/i386/kvm/kvm_i386.h b/target/i386/kvm/kvm_i386.h
index 34fc60774b..26d7c57512 100644
--- a/target/i386/kvm/kvm_i386.h
+++ b/target/i386/kvm/kvm_i386.h
@@ -74,9 +74,6 @@ typedef struct kvm_msr_handlers {
      QEMUWRMSRHandler *wrmsr;
  } KVMMSRHandlers;

Isn't it also valid for QEMURDMSRHandler,  QEMUWRMSRHandler and
KVMMSRHandlers definitions?

  
-bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
-                    QEMUWRMSRHandler *wrmsr);
-
  #endif /* CONFIG_KVM */









