On Fri, Aug 16, 2024 at 03:31:46PM +0800, Xu Yilun wrote: > > diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c > > index 84cd9b4f90b5..a0954c3928e2 100644 > > --- a/arch/x86/kvm/vmx/tdx.c > > +++ b/arch/x86/kvm/vmx/tdx.c > > @@ -5,6 +5,7 @@ > > #include "x86_ops.h" > > #include "mmu.h" > > #include "tdx.h" > > +#include "tdx_ops.h" > > I remember patch #4 says "C files should never include this header > directly" > > +++ b/arch/x86/kvm/vmx/tdx_ops.h > @@ -0,0 +1,387 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Constants/data definitions for TDX SEAMCALLs > + * > + * This file is included by "tdx.h" after declarations of 'struct > + * kvm_tdx' and 'struct vcpu_tdx'. C file should never include > + * this header directly. > + */ > > maybe just remove it? Yes doing patch to drop it thanks. Tony
