On Mon, Aug 19, 2024 at 09:17:10AM +0800, Tao Su wrote: > On Mon, Aug 12, 2024 at 03:48:07PM -0700, Rick Edgecombe wrote: > > From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx> > > --- a/arch/x86/kvm/vmx/tdx.c > > +++ b/arch/x86/kvm/vmx/tdx.c > > @@ -44,6 +44,35 @@ struct kvm_tdx_caps { > > > > static struct kvm_tdx_caps *kvm_tdx_caps; > > > > +int tdx_vm_enable_cap(struct kvm *kvm, struct kvm_enable_cap *cap) > > +{ > > + int r; > > + > > + switch (cap->cap) { > > + case KVM_CAP_MAX_VCPUS: { > > How about delete the curly braces on the case? Thanks I'll do a patch to drop these. And there's an unpaired if else bracket cosmetic issue there too. > > + if (cap->flags || cap->args[0] == 0) > > + return -EINVAL; > > + if (cap->args[0] > KVM_MAX_VCPUS || > > + cap->args[0] > tdx_sysinfo->td_conf.max_vcpus_per_td) > > + return -E2BIG; > > + > > + mutex_lock(&kvm->lock); > > + if (kvm->created_vcpus) > > + r = -EBUSY; > > + else { > > + kvm->max_vcpus = cap->args[0]; > > + r = 0; > > + } > > + mutex_unlock(&kvm->lock); > > + break; > > + } > > + default: > > + r = -EINVAL; > > + break; > > + } And adding a line break here after the switch. > > + return r; > > +} Regards, Tony